Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WinUI3: ContentDialog is missing entrance animation #8476

Open
Aurumaker72 opened this issue May 12, 2023 · 14 comments
Open

WinUI3: ContentDialog is missing entrance animation #8476

Aurumaker72 opened this issue May 12, 2023 · 14 comments
Labels
area-Dialogs bug Something isn't working team-Controls Issue for the Controls team

Comments

@Aurumaker72
Copy link

Describe the bug

ContentDialog doesn't have an entrance animation, but has an exiting animation.

This is a possible regression, as the Windows 11 Settings app does feature ContentDialogs with entrance animations (see Windows Insider Program tab)

Steps to reproduce the bug

  1. Create a ContentDialog with an appropriate XamlRoot and arbitrary text
  2. Await the ContentDialog's ShowAsync method
  3. Observe the ContentDialog instantly appearing with no animation.

Expected behavior

The ContentDialog is expected to enter with an animation, similar to what is seen in Fluent.

Screenshots

ContentDialog.mp4

NuGet package version

WinUI 3 - Windows App SDK 1.3.1: 1.3.230502000

Windows version

Windows 11 (22H2): Build 22621

Additional context

No response

@Aurumaker72 Aurumaker72 added the bug Something isn't working label May 12, 2023
@IstvanKor
Copy link

Maybe missing style assignment to your ContentDialog.

ContentDialog dialog = new ContentDialog();
....
dialog.Style = Application.Current.Resources["DefaultContentDialogStyle"] as Style;
....
await dialog.ShowAsync();

@Aurumaker72
Copy link
Author

Maybe missing style assignment to your ContentDialog.

This indeed fixes the issue.
It, on the other hand, begs the question: shouldn't this be assigned by default? The OOB experience is suboptimal enough as-is.

@Balkoth
Copy link

Balkoth commented May 15, 2023

Seems strange to me that the default style is not applied automatically...
Is this a problem on other controls too?

@Aurumaker72
Copy link
Author

Is this a problem on other controls too?

I haven't tested extensively, but all the basic controls (Button, CheckBox, ComboBox, RadioButton, Slider), collection controls, and navigation controls seem perfectly fine.

@zadjii-msft
Copy link
Member

Looks like a dupe of #5573 to me.

@IstvanKor
Copy link

Looks like a dupe of #5573 to me.

#5573 is related to WinUi 2.X, this issue to WinUI 3.

@Aurumaker72
Copy link
Author

Also, the proposed solution in #5573 does not work.

@Balkoth
Copy link

Balkoth commented Jul 13, 2023

This is still an issue in Windows App SDK 1.3.2 (1.3.230602002)

@bpulliam bpulliam added the team-Controls Issue for the Controls team label Aug 22, 2023
@ranjeshj ranjeshj changed the title ContentDialog is missing entrance animation WinUI3: ContentDialog is missing entrance animation Dec 7, 2023
@lolametro
Copy link

This is an issue again in Windows App SDK 1.6-experimental-1.

@lolametro
Copy link

This is still an issue in Windows App SDK 1.6-preview-1.

Just to clarify: the workaround above (#8476 (comment) assign the style) does not help here. In 1.5 it still worked fine.
Please fix this regression before releasing 1.6!

@lolametro
Copy link

This is still an issue in the released Windows App SDK 1.6. 🙂

@Balkoth
Copy link

Balkoth commented Sep 13, 2024

Super strange that the exit animation is still there...

@kirwan-safesurfer
Copy link

This is still an issue in the released Windows App SDK 1.6. 🙂

Also wanted to corroborate that this is a 1.6 regression not present in Windows App SDK 1.5.6.

@lolametro
Copy link

lolametro commented Oct 2, 2024

This was fixed in Windows App SDK 1.6.1 (1.6.240923002) 🙏 Probably as a side effect of #8402.

At least when setting the style like described in #8476 (comment). Without setting the style, there's still no animation, but at least the workaround works again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Dialogs bug Something isn't working team-Controls Issue for the Controls team
Projects
None yet
Development

No branches or pull requests

8 participants