Move NavigationView to Repeater

[ojhad]

Also fixes ItemsRepeater bug #1671

Description

Replaced ListView with ItemsRepeater in NavigationView.

Motivation and Context

Issue #378
Issue #1477
NavigationView's dependency on ListView is a drawback in places where we have to circumvent some of ListView's existing behaviors which results in complicated codepaths and is a way for bugs to be introduced. As more behavior gets added to the control, the more we have to fight with ListView in order to get desired behavior. Moving to ItemsRepeater will provide us more freedom in implementing future functionality as well as resolve some issues that the control currently has due to the usage of ListView.

How Has This Been Tested?

• Added to and ran current test corpus
• Tested with some customer apps such as XamlControlsGallery, Calculator, etc.

[licanhua]

unsealed runtimeclass StackLayout : VirtualizingLayout

I don't know which one will be better.
NonVirtualizingStackLayout vs StackLayout with flag to disable virtualization.
We defined NonVirtualizingLayout, but we didn't use it. it's wierd #Resolved

---

Refers to: dev/Repeater/ItemsRepeater.idl:423 in 196b57d. [](commit_id = 196b57d, deletion_comment = False)

[StephenLPeters]

return position;

return a default value here #Resolved

---

Refers to: dev/NavigationView/NavigationViewItemAutomationPeer.cpp:192 in b9d33f5. [](commit_id = b9d33f5, deletion_comment = False)

[ojhad]

if (const auto& nvi = container)

This check is verifying that the passed in parameter is not null.

---

In reply to: 568038366 [](ancestors = 568038366)

---

Refers to: dev/NavigationView/NavigationView.cpp:2065 in b9d33f5. [](commit_id = b9d33f5, deletion_comment = False)

[StephenLPeters]

if (const auto& nvi = container)

its kindof a weird way to do that, why not just

if(container)
{
    if(auto const element = container.try_as<winrt::UIElement>())
    {

---

In reply to: 568130439 [](ancestors = 568130439,568038366)

---

Refers to: dev/NavigationView/NavigationView.cpp:2065 in b9d33f5. [](commit_id = b9d33f5, deletion_comment = False)

[ojhad]

/azp run #Resolved

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

#Resolved

[ojhad]

void NavigationView::UpdateTitleBarPadding()

I don't see any reason this could not be, but maybe because margins and height is being updated on multiple elements, to keep everything consistent? I think its best to leave this as is for now.

---

In reply to: 560544059 [](ancestors = 560544059)

---

Refers to: dev/NavigationView/NavigationView.cpp:3612 in 196b57d. [](commit_id = 196b57d, deletion_comment = False)

[ojhad]

/azp run #Resolved

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

#Resolved

[azure-pipelines]

No pipelines are associated with this pull request.

#Resolved

[azure-pipelines]

No pipelines are associated with this pull request.

#Resolved

[StephenLPeters]