-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed NavView in ContentDialog crash #2920
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
dev/NavigationView/NavigationView_InteractionTests/CommonTests.cs
Outdated
Show resolved
Hide resolved
@ojhad you have some visual verification failures |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
more visual verification issues, as @Felix-Dev noted, i think the pipeline is broken. hopefully @kmahone can take a look when he gets back. |
There was an issue in the processhelixfiles.ps1 script. I have a fix out for PR: #2959 |
If you merge the latest master to pick up #2959 it should resolve the issue with the PR run. |
3a71442
to
89a6e37
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
89a6e37
to
36893dc
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
ede73b4
to
47f8b92
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
When NavView is shown in a ContentDialog, there is a scenario where the SplitView tries to add children to the popup root while it is being measured (which causes a crash since NavView itself is in the popup root). Due to the fact that this SplitView API call (updating the DisplayMode property) modifies elements in the tree outside of itself, we should defer that call, whenever it comes from OnApplyTemplate, to be executed in the OnLoaded callback.
Motivation and Context
Fixes #2713
How Has This Been Tested?
Added interaction test