Fixed NavView in ContentDialog crash #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-NavigationView
dev/NavigationView/NavigationView_InteractionTests/CommonTests.cs
Outdated
Show resolved
Hide resolved
|
@ojhad you have some visual verification failures |
StephenLPeters
approved these changes
Jul 17, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
more visual verification issues, as @Felix-Dev noted, i think the pipeline is broken. hopefully @kmahone can take a look when he gets back. |
There was an issue in the processhelixfiles.ps1 script. I have a fix out for PR: #2959 |
|
If you merge the latest master to pick up #2959 it should resolve the issue with the PR run. |
ojhad
force-pushed
the
user/ojhad/contentdialognavviewfix
branch
from
3a71442
to
89a6e37
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
force-pushed
the
user/ojhad/contentdialognavviewfix
branch
from
89a6e37
to
36893dc
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
force-pushed
the
user/ojhad/contentdialognavviewfix
branch
from
ede73b4
to
47f8b92
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When NavView is shown in a ContentDialog, there is a scenario where the SplitView tries to add children to the popup root while it is being measured (which causes a crash since NavView itself is in the popup root). Due to the fact that this SplitView API call (updating the DisplayMode property) modifies elements in the tree outside of itself, we should defer that call, whenever it comes from OnApplyTemplate, to be executed in the OnLoaded callback.
Motivation and Context
Fixes #2713
How Has This Been Tested?
Added interaction test