NavigationView: Fix app crash in Top mode when clearing the item collection while a selected item exists #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msft-github-bot
added
the
needs-triage
YuliKl
added
area-NavigationView
ad1Dima
reviewed
Aug 29, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Felix-Dev
deleted the
user/Felix-Dev/navview-itemscollection-clear-crash-fix
branch
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Sep 6, 2020
…ection while a selected item exists (microsoft/microsoft-ui-xaml#3202)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a regression introduced with PR #1997 which manifested itself in an app crash. The crash occured when the NavigationView is
Motivation and Context
Fixes #3200
How Has This Been Tested?
Tested manually and added API test.