Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Slider Examples #3821

Closed
wants to merge 1 commit into from
Closed

Added Slider Examples #3821

wants to merge 1 commit into from

Conversation

mdtauk
Copy link
Contributor

@mdtauk mdtauk commented Dec 17, 2020

Additional sliders for test UI

I am Adding extra Slider control examples to the TestUI/SliderPage.xaml to include examples of TickPlacement properties - as well as adding vertically orientated examples.

  • I used a Grid with columns to separate the Horizontal and Vertical examples
  • I wrapped each StackPanel in a ScrollViewer as the vertical examples would extend beyond the visible region with the lab conditions bounding toggled.
  • I added Margin values to the controls and panels to make it easier to identify each example.

Motivation and Context

Following a suggestion I made in Pull Request #3768 by @karenbtlai I was asked to make a Pull Request adding more Slider examples to the TestUI SliderPage

How Has This Been Tested?

I built the solution and ran the MUXTestApp, checking the Page displayed correctly.

Screenshots (if appropriate):

Light Theme Slider Page

Dark Theme toggled Slider Page

This is my first time ever making a Pull Request, so I apologise if I have made any mistakes or an etiquette faux pas

Added Examples of Sliders with TickPlacements as well as Vertical Slider examples
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Dec 17, 2020
@mdtauk mdtauk changed the title AddedSliderExamples Added Slider Examples Dec 17, 2020
Copy link
Contributor

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

@YuliKl YuliKl added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-Slider team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Dec 18, 2020
@karkarl
Copy link
Contributor

karkarl commented Dec 28, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@karkarl karkarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks again :)

@karkarl
Copy link
Contributor

karkarl commented Jan 27, 2021

@mdtauk would you be able to pull from master for the failing tests? I'd love to merge this in.

@mdtauk
Copy link
Contributor Author

mdtauk commented Jan 27, 2021

I am closing this pull request as I messed up the branching, and couldn't figure out how to commit to this existing request.
#4040 is the new one

@mdtauk mdtauk closed this Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency area-Slider team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants