[infra] Improve test app UIs and usability, switch to fast pass rendering #4426

marcelwgn · 2021-03-05T19:05:20Z

Description

Improved multiple test pages to be usable without UIA software, also switched to fast pass rendering where reasonable.

For math fun facts, check out the commit messages of my commits (non merge commits).

Motivation and Context

Make test app more usable and friendly.

How Has This Been Tested?

Tested manually, also ran selection of interaction tests.

Screenshots (if appropriate):

StephenLPeters · 2021-03-06T00:15:19Z

What is the goal of these changes?

marcelwgn · 2021-03-06T08:23:07Z

@StephenLPeters Pretty much the same as #1793. Improve UI, fix pages where not everything could be accessed without UIA on CI dimensions or the pages where hard to use due to difficult contrast ratios. As part of this, I also went through all the TextBlocks and updated them to use fast pass rendering. Not sure though why the commit history looks the way it does though. Also the latest commit was an accident, removed that now.

… way that you can assemble two spheres out of it with same volume (Banach Tarski Paradox)

…""not listable""), there exists a well-ordering of the real numbers (ZFC & axiom of choice)

…athematics went through a crisis since there was no clear axiomatic foundation for Math; this was eventually solved by using set theory (ZFC) as foundation

…of digits, it is neither poven nor disproven that pi contains any sequence of digits (i.e. it is a normal number). most normal numbers we know are constructed (e.g. Champerowne's constant)

…he only holomorphic (complex differentiable) functions with a global maximum are constants, all other holomorphic functions have no global maximum besides on the domain boundary

marcelwgn · 2021-03-08T00:37:12Z

Fixed the commit history, sorry that so many folks were pinged by my lacking rebasing skills. This commit history makes a lot more sense.

ranjeshj · 2021-03-09T02:08:32Z

dev/RadioButtons/InteractionTests/RadioButtonsTests.cs

@@ -142,7 +142,7 @@ public void FocusComingFromAnotherRepeaterTest()
                VerifySelectedFocusedIndex(2, true);

                // Move focus to the first RadioButtons control by pressing TAB again
-                KeyboardHelper.PressKey(Key.Tab);
+                KeyboardHelper.PressKey(Key.Tab, ModifierKey.Shift);


Is this intentional ?

Yes, the old test assumed that moving forward in tab order loops back to the first RadioButtons since we hid the test app bar and thus move to the first control in the page. However since we no longer hide the testapp bar, we need to move backwards instead.

Curious as to why you are removing the bit to hide test app bar?

IIRC, you couldn't really leave the app after that since the only way to get back was using some off screen elements that are triggered through UIA when executing tests.

dev/RadioButtons/TestUI/RadioButtonsFocusPage.xaml.cs

ranjeshj · 2021-03-09T02:16:23Z

/azp run

azure-pipelines · 2021-03-09T02:16:40Z

Azure Pipelines successfully started running 1 pipeline(s).

StephenLPeters · 2021-03-10T21:34:09Z

/azp run

azure-pipelines · 2021-03-10T21:34:27Z

Azure Pipelines successfully started running 1 pipeline(s).

ranjeshj · 2021-03-11T16:38:19Z

/azp run

azure-pipelines · 2021-03-11T16:38:35Z

Azure Pipelines successfully started running 1 pipeline(s).

marcelwgn · 2021-05-02T19:09:32Z

All tests should work now, could we merge this PR then or are there other things that need addressing?

StephenLPeters · 2021-05-03T17:20:55Z

/azp run

azure-pipelines · 2021-05-03T17:21:07Z

Azure Pipelines successfully started running 1 pipeline(s).

marcelwgn · 2021-05-04T20:26:45Z

@StephenLPeters A few verification tests failed, but I have no idea why since those aren't actually affected by the test app UI are they? Also if we have verification fails, shouldn't the drop contain the updated files? My guess is that it was just a bad run, maybe the merge with main fixes this.

StephenLPeters · 2021-05-04T20:41:08Z

@StephenLPeters A few verification tests failed, but I have no idea why since those aren't actually affected by the test app UI are they? Also if we have verification fails, shouldn't the drop contain the updated files? My guess is that it was just a bad run, maybe the merge with main fixes this.

We actually changed how the pipelines are organized a bit which resulted in some changes to the VisualVerification test work flow. The updated documentation is in the developer guide: https://github.com/microsoft/microsoft-ui-xaml/blob/main/docs/developer_guide.md#visual-tree-verification-tests.

Can you post a link to the ADO pipeline and I'll take a look. (or I can dig it up if you don't have it handy.)

StephenLPeters · 2021-05-04T20:41:12Z

/azp run

azure-pipelines · 2021-05-04T20:41:23Z

Azure Pipelines successfully started running 1 pipeline(s).

marcelwgn · 2021-05-05T17:27:46Z

I think I found out why a lot of tests failed: I accidently checked in a change to the test app where it used the Version1 styles instead of the Version2 styles which of course broke a lot of verification tests (and some other tests too).

StephenLPeters · 2021-07-19T21:24:47Z

/azp run

azure-pipelines · 2021-07-19T21:24:58Z

Azure Pipelines successfully started running 1 pipeline(s).

karkarl · 2021-11-08T17:56:52Z

/azp run

azure-pipelines · 2021-11-08T17:57:04Z

Azure Pipelines successfully started running 1 pipeline(s).

karkarl · 2021-11-10T00:34:02Z

/azp run

azure-pipelines · 2021-11-10T00:34:13Z

Azure Pipelines successfully started running 1 pipeline(s).

karkarl · 2021-11-10T02:45:24Z

dev/RadialGradientBrush/TestUI/RadialGradientBrushPage.xaml

@@ -7,7 +7,7 @@
    xmlns:local="using:MUXControlsTestApp"
    xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
    xmlns:media="using:Microsoft.UI.Xaml.Media"
-    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
+    xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" xmlns:contract5Present="http://schemas.microsoft.com/winfx/2006/xaml/presentation?IsApiContractPresent(Windows.Foundation.UniversalApiContract, 5)"


nit: new line

Good point, fixed now (albeit a nit).

karkarl · 2021-11-10T02:58:28Z

I manually compared the before and after MUXControlsTestApps and they look great! Thanks for doing this.

karkarl · 2021-11-10T18:51:18Z

/azp run

azure-pipelines · 2021-11-10T18:51:30Z

Azure Pipelines successfully started running 1 pipeline(s).

marcelwgn · 2021-11-10T18:55:06Z

Thank you for reviewing this large PR @karenbtlai !!!

ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 5, 2021

StephenLPeters added area-TestInfrastructure Issue in the test infrastructure (e.g. in Helix scripts) team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 6, 2021

marcelwgn force-pushed the user/chingucoding/testapp-ui-improvements branch from f787f12 to a70820f Compare March 6, 2021 08:22

marcelwgn force-pushed the user/chingucoding/testapp-ui-improvements branch from 97c43bb to a70820f Compare March 7, 2021 23:23

marcelwgn added 6 commits March 8, 2021 01:28

First round of changes; Fun fact: you can slice up a sphere in such a…

a6fc03e

… way that you can assemble two spheres out of it with same volume (Banach Tarski Paradox)

Second round of changes; Fun fact: Despite being an uncountable set (…

decd6fb

…""not listable""), there exists a well-ordering of the real numbers (ZFC & axiom of choice)

Merge branch 'master' into user/chingucoding/testapp-ui-improvements

8d66e35

Third round of changes; Fun fact: At the start of the 20th century, m…

526ea4e

…athematics went through a crisis since there was no clear axiomatic foundation for Math; this was eventually solved by using set theory (ZFC) as foundation

Fourth round of changes; Fun fact: Despite having an infinite number …

8c10f6a

…of digits, it is neither poven nor disproven that pi contains any sequence of digits (i.e. it is a normal number). most normal numbers we know are constructed (e.g. Champerowne's constant)

Fifth round of changes, switching to fast pass rendering; Fun fact: T…

a3aed91

…he only holomorphic (complex differentiable) functions with a global maximum are constants, all other holomorphic functions have no global maximum besides on the domain boundary

marcelwgn force-pushed the user/chingucoding/testapp-ui-improvements branch from a70820f to a3aed91 Compare March 8, 2021 00:34

Merge branch 'master' into user/chingucoding/testapp-ui-improvements

b180cf6

Bring back ProgressBarPage changes

37dfbe9

ranjeshj reviewed Mar 9, 2021

View reviewed changes

dev/RadioButtons/TestUI/RadioButtonsFocusPage.xaml.cs Show resolved Hide resolved

marcelwgn added 2 commits March 9, 2021 17:38

Possibly fix test failure

c68b123

Merge branch 'master' into user/chingucoding/testapp-ui-improvements

79baac8

Fix bad merge

8f03eb2

Merge branch 'main' into user/chingucoding/testapp-ui-improvements

3646b99

Merge branch 'main' into user/chingucoding/testapp-ui-improvements

76e2067

Revert version setting

48fb1ca

marcelwgn added 2 commits May 26, 2021 21:34

Merge branch 'main' into user/chingucoding/testapp-ui-improvements

fe86287

Merge branch 'main' into user/chingucoding/testapp-ui-improvements

6e8b203

Merge branch 'main' into user/chingucoding/testapp-ui-improvements

d8fed8b

update verification files

0572cf3

karkarl reviewed Nov 10, 2021

View reviewed changes

karkarl approved these changes Nov 10, 2021

View reviewed changes

Fix formatting

9db70d3

karkarl merged commit feb7029 into microsoft:main Nov 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[infra] Improve test app UIs and usability, switch to fast pass rendering #4426

[infra] Improve test app UIs and usability, switch to fast pass rendering #4426

marcelwgn commented Mar 5, 2021

StephenLPeters commented Mar 6, 2021

marcelwgn commented Mar 6, 2021

marcelwgn commented Mar 8, 2021

ranjeshj Mar 9, 2021

marcelwgn Mar 9, 2021 •

edited

Loading

karkarl Nov 10, 2021

marcelwgn Nov 10, 2021

ranjeshj commented Mar 9, 2021

azure-pipelines bot commented Mar 9, 2021

StephenLPeters commented Mar 10, 2021

azure-pipelines bot commented Mar 10, 2021

ranjeshj commented Mar 11, 2021

azure-pipelines bot commented Mar 11, 2021

marcelwgn commented May 2, 2021

StephenLPeters commented May 3, 2021

azure-pipelines bot commented May 3, 2021

marcelwgn commented May 4, 2021

StephenLPeters commented May 4, 2021

StephenLPeters commented May 4, 2021

azure-pipelines bot commented May 4, 2021

marcelwgn commented May 5, 2021

StephenLPeters commented Jul 19, 2021

azure-pipelines bot commented Jul 19, 2021

karkarl commented Nov 8, 2021

azure-pipelines bot commented Nov 8, 2021

karkarl commented Nov 10, 2021

azure-pipelines bot commented Nov 10, 2021

karkarl Nov 10, 2021

marcelwgn Nov 10, 2021

karkarl commented Nov 10, 2021

karkarl commented Nov 10, 2021

azure-pipelines bot commented Nov 10, 2021

marcelwgn commented Nov 10, 2021

[infra] Improve test app UIs and usability, switch to fast pass rendering #4426

[infra] Improve test app UIs and usability, switch to fast pass rendering #4426

Conversation

marcelwgn commented Mar 5, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

StephenLPeters commented Mar 6, 2021

marcelwgn commented Mar 6, 2021

marcelwgn commented Mar 8, 2021

ranjeshj Mar 9, 2021

Choose a reason for hiding this comment

marcelwgn Mar 9, 2021 • edited Loading

Choose a reason for hiding this comment

karkarl Nov 10, 2021

Choose a reason for hiding this comment

marcelwgn Nov 10, 2021

Choose a reason for hiding this comment

ranjeshj commented Mar 9, 2021

azure-pipelines bot commented Mar 9, 2021

StephenLPeters commented Mar 10, 2021

azure-pipelines bot commented Mar 10, 2021

ranjeshj commented Mar 11, 2021

azure-pipelines bot commented Mar 11, 2021

marcelwgn commented May 2, 2021

StephenLPeters commented May 3, 2021

azure-pipelines bot commented May 3, 2021

marcelwgn commented May 4, 2021

StephenLPeters commented May 4, 2021

StephenLPeters commented May 4, 2021

azure-pipelines bot commented May 4, 2021

marcelwgn commented May 5, 2021

StephenLPeters commented Jul 19, 2021

azure-pipelines bot commented Jul 19, 2021

karkarl commented Nov 8, 2021

azure-pipelines bot commented Nov 8, 2021

karkarl commented Nov 10, 2021

azure-pipelines bot commented Nov 10, 2021

karkarl Nov 10, 2021

Choose a reason for hiding this comment

marcelwgn Nov 10, 2021

Choose a reason for hiding this comment

karkarl commented Nov 10, 2021

karkarl commented Nov 10, 2021

azure-pipelines bot commented Nov 10, 2021

marcelwgn commented Nov 10, 2021

marcelwgn Mar 9, 2021 •

edited

Loading