ContentDialog - supports Min\Max sizes #5872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
|
@alexdi220 Can you accept the the CLA agreement before we run the pipeline to verify your change? :) |
|
@StephenLPeters done |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-Dialogs
team-Controls
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Looks like the VerifyVisualTreeTests are failing. @alexdi220 would you be able to update the verification files? |
|
build aged out :/ |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
approved these changes
Nov 10, 2021
|
@karenbtlai these VisualVerification updates don't make sense to me. Why does the RS2 version of the verification have a RenderSize=320,184 but the RS3 version has RenderSize=0,0? |
StephenLPeters
added a commit
that referenced
this pull request
Jan 10, 2022
* revert 5872 * update visual verification files for consistently failing, but unrelated test failure in CalendarView. This test is failing across the board of Lab Runs for multiple PR's and I am attributing the error to a change in the lab environment. I don't think it is worth the time to verify where this failure is originating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The minimal fix of the issue.
Motivation and Context
The ContentDialog can't manage Min\Max sizes out of box. This pretty little but annoying bug. Related issue #424
How Has This Been Tested?
Screenshots (if appropriate):