Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CommandBar] Switch to themeresource binding for ellipsisbutton #6004

Merged
merged 1 commit into from
Oct 7, 2021
Merged

[CommandBar] Switch to themeresource binding for ellipsisbutton #6004

merged 1 commit into from
Oct 7, 2021

Conversation

marcelwgn
Copy link
Contributor

Description

Due to limitations in resource lookup, using staticresource binding is not ideal, using themeresource binding is better here.

Motivation and Context

Closes #5980

How Has This Been Tested?

Screenshots (if appropriate):

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 1, 2021
@beervoley
Copy link
Contributor

/azp run

@beervoley beervoley added the area-Commanding AppBar, UICommand, MVVM, etc label Oct 1, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@beervoley beervoley added the team-Controls Issue for the Controls team label Oct 1, 2021
@beervoley
Copy link
Contributor

@chingucoding thanks for the fix Marcel!

@ranjeshj ranjeshj removed the needs-triage Issue needs to be triaged by the area owners label Oct 6, 2021
@StephenLPeters StephenLPeters merged commit f1dc556 into microsoft:main Oct 7, 2021
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Apr 14, 2022
Closed
Closed
Merged
@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-Commanding AppBar, UICommand, MVVM, etc team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to override CommandBar's MoreButton "EllipsisButton" style
4 participants
@marcelwgn @beervoley @StephenLPeters @ranjeshj