Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Appbar ] [ HC ] AppBarToggleButton icon is not visible in high-contrast hover + press states #6015

Merged
merged 1 commit into from
Oct 4, 2021
Merged

[ Appbar ] [ HC ] AppBarToggleButton icon is not visible in high-contrast hover + press states #6015

merged 1 commit into from
Oct 4, 2021

Conversation

tashatitova
Copy link
Contributor

@tashatitova tashatitova commented Oct 1, 2021 •
edited
Loading

Fixing actual hover/press HC bug for appbar toggle (on the left)

before

Fixed unchecked hover + press (ignore long label, for testing only)

updated

Fixed checked hover + press:

checked-hover

Misc: white space for readability

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 1, 2021
@tashatitova
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tashatitova tashatitova merged commit 177458c into main Oct 4, 2021
@tashatitova tashatitova deleted the user/tatito/appbar branch October 4, 2021 17:17
@ranjeshj ranjeshj added area-Commanding AppBar, UICommand, MVVM, etc area-Styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 6, 2021
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karkarl karkarl karkarl approved these changes

@marksfoster marksfoster marksfoster approved these changes

@ranjeshj ranjeshj Awaiting requested review from ranjeshj

@teaP teaP Awaiting requested review from teaP

Assignees
No one assigned
Labels
area-Commanding AppBar, UICommand, MVVM, etc area-Styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tashatitova @karkarl @marksfoster @ranjeshj