Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Pivot.SelectedPipe color and thickness the same way as was changed NavigationViewItem...WhenOnTop #6082

Merged
merged 1 commit into from
Oct 25, 2021
Merged

Change Pivot.SelectedPipe color and thickness the same way as was changed NavigationViewItem...WhenOnTop #6082

merged 1 commit into from
Oct 25, 2021

Conversation

eugenegff
Copy link
Contributor

Pivot styles were not updated for Version2, and now selection pipe in it significantly differs by color and thickness from all other controls with selection pipes, like NavigationView, ListView, ComboBox, etc. This fix adjusts "selection pipe" of the Pivot control the same way as "selection pipe" of the MUX_NavigationViewItemPresenterStyleWhenOnTopPane was adjusted for Version2.

image

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 11, 2021
@eugenegff
Copy link
Contributor Author

@StephenLPeters FYI

@StephenLPeters
Copy link
Contributor

@chigy fyi

@mdtauk
Copy link
Contributor

mdtauk commented Oct 12, 2021 •
edited
Loading

#4492 Discussion: Keeping Pivot in WinUI 3

#3957 Proposal: Pivot visual refresh

@ghost
Copy link

ghost commented Oct 12, 2021

I suggest making it 16px wide, just like all other selectors.

@eugenegff
Copy link
Contributor Author

eugenegff commented Oct 12, 2021 •
edited
Loading

I suggest making it 16px wide, just like all other selectors.

That is out of scope of this PR - it is intentionally minimal to increase chances of being accepted fast.

@eugenegff eugenegff force-pushed the Pivot-selectedpipe-color-and-thickness-fix branch from d3bf275 to b880f8b Compare October 12, 2021 13:21
@eugenegff
Change Pivot.SelectedPipe color and thickness to match NavigationView…
5e30d16 
…Item...OnTopPane.SelectionIndicator appearance
@eugenegff eugenegff force-pushed the Pivot-selectedpipe-color-and-thickness-fix branch from b880f8b to 5e30d16 Compare October 12, 2021 13:32
@StephenLPeters StephenLPeters added area-Pivot area-Styling team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 20, 2021
@eugenegff
Copy link
Contributor Author

@StephenLPeters I implemented requested changes, your approval is required to unblock the PR.

@StephenLPeters
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters merged commit 62de7e8 into microsoft:main Oct 25, 2021
@eugenegff eugenegff deleted the Pivot-selectedpipe-color-and-thickness-fix branch October 25, 2021 23:05
@ghost
Copy link

ghost commented Apr 14, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220413001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jan 3, 2023

🎉Microsoft.UI.Xaml v2.8.2 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Assignees
No one assigned
Labels
area-Pivot area-Styling team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugenegff @StephenLPeters @mdtauk