-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Pivot.SelectedPipe color and thickness the same way as was changed NavigationViewItem...WhenOnTop #6082
Change Pivot.SelectedPipe color and thickness the same way as was changed NavigationViewItem...WhenOnTop #6082
Conversation
@StephenLPeters FYI |
@chigy fyi |
I suggest making it 16px wide, just like all other selectors. |
That is out of scope of this PR - it is intentionally minimal to increase chances of being accepted fast. |
d3bf275
to
b880f8b
Compare
…Item...OnTopPane.SelectionIndicator appearance
b880f8b
to
5e30d16
Compare
@StephenLPeters I implemented requested changes, your approval is required to unblock the PR. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
🎉 Handy links: |
Pivot styles were not updated for Version2, and now selection pipe in it significantly differs by color and thickness from all other controls with selection pipes, like NavigationView, ListView, ComboBox, etc. This fix adjusts "selection pipe" of the Pivot control the same way as "selection pipe" of the MUX_NavigationViewItemPresenterStyleWhenOnTopPane was adjusted for Version2.