Refactor ensuring WebView2 runtime, add WebView2 TestSuite D #6120
Conversation
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
krschau
force-pushed
the
user/krschau/ensure-runtime
branch
from
89ccc29
to
5356c37
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-TestInfrastructure
krschau
force-pushed
the
user/krschau/ensure-runtime
branch
from
5356c37
to
3f9d08e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -114,53 +176,63 @@ public static void EnsureBrowser() | |||
| { | |||
| Log.Error("WebView2Tests Init: could not find loader at {0} [exception: {1}]", loaderPath, e.ToString()); | |||
| } | |||
| return loaderBuildVersion; | |||
There was a problem hiding this comment.
We no longer rely on webview2loader.dll (in favor of the winrt wrapper)... is it ok to still rely on geting the version from this file (which is still present in the package for COM CWV2SDK)? I wonder if there is a better way to get the "SDK version"... #WontFix
There was a problem hiding this comment.
Let's keep for now and update in another change.
| @@ -65,16 +65,75 @@ private static void DownloadFile(string url, string filePath) | |||
| task.Wait(TimeSpan.FromMinutes(10)); | |||
| } | |||
|
|
|||
| // Ensure a suitable version of Anaheim Browser is present, if not use mini_installer to install one on the beta channel. | |||
| // Ensure a suitable version of Anaheim Browser is present, if not use mini_installer to install the runtime. | |||
| } | ||
| } | ||
| } | ||
|
|
||
| private static Microsoft.Win32.RegistryKey GetBrowserExecutableFolderKey() | ||
| { | ||
| return Microsoft.Win32.Registry.LocalMachine.CreateSubKey(@"Software\Policies\Microsoft\Edge\WebView2\BrowserExecutableFolder", true); |
There was a problem hiding this comment.
Let's keep for now and update in another change.
|
@jevansaks and @DmitriyKomin is this ready to check in? In reply to: 951275901 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
yep, just approved. Thanks! In reply to: 951275901 |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
Cleans up code for ensuring a machine has the proper WebView2 runtime before running tests. Also splits WebView2 tests into four test suites instead of three, to guard against hitting timeouts from trying to run too many tests.