Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightly build: don't push vpack #6188

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

kmahone
Copy link
Member

@kmahone kmahone commented Oct 28, 2021

I am setting up a scheduled Pipeline build to run the equivalent of what we run for the Release build. This is so that if there are any issues with this Pipeline we will catch it early rather than just at the time where we are running a release.

One thing we don't want to do in this nightly build is to push the various vpacks. This is for two reasons:

  1. The versions would collide with the Release Pipeline, since we don't do anything to differentiate them.
  2. We would be pushing a bunch of vpacks that we don't intend to use

So, we set a condition on the 'vpack push' tasks to only push in the 'real' release pipeline.

This fix is related to #6174.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Oct 28, 2021
@kmahone
Copy link
Member Author

kmahone commented Oct 28, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephenLPeters StephenLPeters added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Oct 28, 2021
@StephenLPeters
Copy link
Contributor

There is a corresponding change the the pipelines to use this new variable as well I assume.

@kmahone
Copy link
Member Author

kmahone commented Oct 29, 2021

There is a corresponding change the the pipelines to use this new variable as well I assume.

Yes. The variable is set to true on the 'real' ReleaseBuild Pipeline and 'false' on the 'test' Pipeline.

@kmahone kmahone merged commit 86cb0cf into main Oct 29, 2021
@kmahone kmahone deleted the user/kmahone/nightlyreleasebuild branch October 29, 2021 00:44
@ghost
Copy link

ghost commented Jul 13, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220712001 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Jul 18, 2022

🎉Microsoft.UI.Xaml v2.8.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants