Fix issue where pips pagers crash when the next or previous arrow button is clicked in RTL flow direction #6607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
StephenLPeters
added
area-PipsPager
team-Controls
kmahone
reviewed
Jan 27, 2022
| tb.Toggle(); | ||
| Wait.ForIdle(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this used anywhere? #Closed
StephenLPeters
commented
Feb 3, 2022
| using (var setup = new TestSetupHelper("PipsPager Tests")) | ||
| { | ||
| elements = new PipsPagerElements(); | ||
| TestSetupHelper.SetInnerFrameFlowDirection(FlowDirection.RightToLeft); |
There was a problem hiding this comment.
@kmahone here #Closed
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FontIcon has code in it that sets a render transform on itself when the flow direction is RTL and the MirroredWhenRIghtToLeft is set to true, in order to mirror the icon using a -1 x-dimension scale. However the PipsPagerNavigationButtonBaseStyle sets a scale transform on the font icon in order to decrease the size of the icon in the pressed state. This is done by referencing the scale transform by name. However the font icon code is overriding the named scale transform with an unnammed one, resulting in a crash when the storyboard tries to reference the named scale transform. We could work around this by referencing the scale transform by property rather than by name, but then we would need to manage the mirrored when RTL scale of -1 ourselves. Instead I've separated the two scale transforms.