Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IsAPIContractVxAvailable to be multi thread safe. #6665

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev/dll/SharedHelpers.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -223,11 +223,11 @@ template <uint16_t APIVersion> bool SharedHelpers::IsAPIContractVxAvailable()
static bool isAPIContractVxAvailable = false;
if (!isAPIContractVxAvailableInitialized)
{
isAPIContractVxAvailableInitialized = true;
// The CBS package is only ever used as a part of the Windows build. Therefore, we can assume that
// all API contracts are present since we can never be running these binaries on a windows build
// that does not match the windows sdk these binaries were compiled against.
isAPIContractVxAvailable = IsInCBSPackage() ? true : winrt::ApiInformation::IsApiContractPresent(L"Windows.Foundation.UniversalApiContract", APIVersion);
isAPIContractVxAvailableInitialized = true;
}

return isAPIContractVxAvailable;
Expand Down