[ MenuBar ] In high contrast, the focus visual overlaps the button border and is barely (or not at all) visible #6730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tashatitova
requested review from
StephenLPeters,
karkarl,
ranjeshj,
teaP and
marksfoster
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
karkarl
approved these changes
Feb 16, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marksfoster
approved these changes
Feb 16, 2022
StephenLPeters
added
accessibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: add negative FocusVisualMargin so that focus border draws outside of the button (common strategy for most controls, was an oversight here it seems). Also added the corner radius to the high contrast border itself so that the inner corner is round, not square in high contrast.
Before:
Updated:
High contrast before:
High contrast fixed:
