-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where an originally-collapsed WebView2 can't be interacted with #6761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
DmitriyKomin
previously requested changes
Feb 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
reviewed
Feb 25, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
reviewed
Mar 1, 2022
codendone
reviewed
Mar 1, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
codendone
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StephenLPeters
added
area-WebView
team-Rendering
Issue for the Rendering team
and removed
needs-triage
Issue needs to be triaged by the area owners
labels
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix here is to add a Grid as Content for the WebView2. This allows WUX hit testing code to find the WebView2, but doesn't get in its way. The size of the Grid is kept in sync with the WebView2 control.
Description
Other changes are:
Motivation and Context
Fixes #6256
How Has This Been Tested?
Added two tests, HiddenThenVisibleTest and ParentHiddenThenVisibleTest. These tests can also be executed manually.