Update TabViewItem BrushResources #6763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -86,10 +86,10 @@ | |||
| <Color x:Key="LayerOnAcrylicFillColorDefault">#09FFFFFF</Color> | |||
| <Color x:Key="LayerOnAccentAcrylicFillColorDefault">#09FFFFFF</Color> | |||
|
|
|||
| <Color x:Key="LayerOnMicaAltFillColorDefault">#733A3A3A</Color> | |||
There was a problem hiding this comment.
There have been CBS packages released since this resource was introduce, which means there is a chance that a consumer of the CBS package is dependent on this named resource and changing the name would break them. To fix this we can either look through the CBS consumers to ensure this wont break, or add the previous name to the DeprecatedResources dictionary.
StephenLPeters
added
area-TabView
team-Controls
tashatitova
approved these changes
Feb 28, 2022
|
Are there updated visuals of these new Mica styles used on tabs? And I am sure this has been considered, but what about Windows 10 users who still don't have a substitute Mica material, where it looks no different to general Window background colours? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TabViewItemHeaderBackgroundSelectedback toSolidBackgroundFillColorTertiaryBrushMotivation and Context
Closes internal bug 38211686