Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProgressRing Automation Name Property #6828

Merged
merged 2 commits into from
Mar 21, 2022
Merged

Fix ProgressRing Automation Name Property #6828

merged 2 commits into from
Mar 21, 2022

Conversation

bkudiess
Copy link
Contributor

Screen readers were reading it the status and name of progress ring as one word, since we were concatenating them without a space.

For example, if you progress ring is called Troubleshooter it was reading "BusyTroubleshooter".

This PR adds the missing space for correct narrator reading.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 14, 2022
kmahone
kmahone approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@kmahone kmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ojhad ojhad added accessibility Narrator, keyboarding, UIA, etc area-Progress ProgressBar, ProgressRing team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Mar 14, 2022
@ranjeshj
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone closed this Mar 18, 2022
@kmahone kmahone reopened this Mar 18, 2022
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Mar 18, 2022
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ojhad ojhad removed the needs-triage Issue needs to be triaged by the area owners label Mar 18, 2022
@bkudiess
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bkudiess bkudiess merged commit 1697d94 into main Mar 21, 2022
@bkudiess bkudiess deleted the user/bakudiess/progressring-narrator-fix branch March 21, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@kmahone kmahone kmahone approved these changes

Assignees
No one assigned
Labels
accessibility Narrator, keyboarding, UIA, etc area-Progress ProgressBar, ProgressRing team-Controls Issue for the Controls team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bkudiess @ranjeshj @StephenLPeters @kmahone @ojhad