Ensure BringIntoView request is not skipped for direct content of ScrollView
#6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
added
area-Scrolling
team-Controls
|
@RBrid could you take a look? |
|
Seems test is failing - I was not able to run tests locally with WinUI solution yet (only under Uno Platform), I will try again |
RBrid
requested changes
Mar 30, 2022
MartinZikmund
force-pushed
the
user/mzikmund/scrollview-bringintoview
branch
from
476fc1b
to
67fe50b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
RBrid
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic in
ScrollPresenterskipsBringIntoViewrequest if it is called for its direct content (even though it may be relevant if it has highMargin.Motivation and Context
Fixes #6888
How Has This Been Tested?
Manually, added API test
Screenshots (if appropriate):