Fixing TabView null ref crash #6987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ojhad
added
team-Controls
ojhad
approved these changes
Apr 18, 2022
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding a null-ref check to avoid an occasional crash.
Internal bug is 38531928. We have had a few crashes where tvi is null. ContainerFromItem(SelectedItem()).try_aswinrt::TabViewItem() must be returning null. I don't know the exact circumstances, so do not have a new regression test. I just confirmed while debugging MuxControlsTestApp that using a null tvi results in the kind of crash reported.
This code was introduced recently with #6632.