Fix WebView2 focus getting stuck #7083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
krschau
added
team-Rendering
codendone
reviewed
May 11, 2022
| // If the next element is this webview, then we are the only focusable element. Move focus back into the webview, | ||
| // or else we'll get stuck trying to tab out of the top or bottom of the page instead of looping around. | ||
| MoveFocusIntoCoreWebView(moveFocusRequestedReason); | ||
| args.Handled(TRUE); |
There was a problem hiding this comment.
This seems fine. What does CoreWebView2 do if we set args.Handled to FALSE -- does it automatically wrap, such that we maybe don't need to MoveFocusIntoCoreWebView()? #Closed
There was a problem hiding this comment.
Just setting it to FALSE did not automatically wrap.
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where when a WebView2 was the only focusable element and the user tabbed through the content, the focus would get stuck at the end (or beginning) of the WebView2. This change prevents the issue by putting focus back in the webview.
Description
After moving focus all the way through a webview, at the end XAML will receive a MoveFocusRequested message where we would normally put focus on the next XAML element. However, in the case where the webview is the ONLY focusable element, focus did not go back to the webview. Instead, we should check if the next focusable element is the same webview that we're leaving, and if it is, put focus back in the WebView2 with a call to CoreWebView2Controller.MoveFocus(). This results in the focus moving from the end back up to the top, or when moving backwards, from the top back down to the end.
How Has This Been Tested?
This has been tested in a standalone app.