Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TabContainer to Transparent on Selected #7110

Merged
merged 1 commit into from
May 18, 2022

Conversation

karkarl
Copy link
Contributor

@karkarl karkarl commented May 17, 2022

Description

Both TabContainer and SelectedBackgroundPath are set to LayerOnMicaBaseAltFillColorDefaultBrush causing the 2 semi transparent layers to overlap, resulting in a diff in colour from the content layer.

The solution is to set TabContainer to transparent on selected visual states.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label May 17, 2022
@ranjeshj ranjeshj requested a review from RBrid May 17, 2022 16:35
@karkarl
Copy link
Contributor Author

karkarl commented May 17, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karkarl karkarl merged commit 8516763 into main May 18, 2022
@karkarl karkarl deleted the user/karenlai/TabViewSelectedTransparencyFix branch May 18, 2022 17:41
@ojhad ojhad added area-TabView team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels May 25, 2022
@ghost
Copy link

ghost commented Jun 2, 2022

🎉Microsoft.UI.Xaml v2.8.0-prerelease.220601001 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-TabView team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants