Revoke HandleAcceleratorKeyActivated when a WebView2 is closed #7117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
krschau
added
area-WebView
team-Rendering
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a WebView2 is closed, we no longer need to forward tab messages to the CoreWebView2. However, the event handler will still try even when the WebView2 is closed if it has not been destroyed, since the auto-revoker won't have kicked in. We should explicitly revoke this handler when Close() is called on the WebView2. Once the webview has been closed, when we get a KeyDown event, we should no longer mark it handled, and instead let normal Xaml tab handling happen.
I also moved some code so some registering and revoking was closer together, and in matching order. (First commit)
Motivation and Context
Without this change, a closed WebView2 will still try to forward the tab to a no-longer-existing hwnd owned by the CoreWebView2, and the app will crash.
How Has This Been Tested?
Added LifetimeStatesTabTest, which tabs past the webview 1) before a core webview is created, 2) after a core webview is created but before any navigation, and 3) after the webview has been closed. I've also verified manually.