Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Velocity in CBS branch #7214

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Conversation

kmahone
Copy link
Member

@kmahone kmahone commented Jun 9, 2022

This enables velocity to be used in the cbs branch. Nothing is using it yet, but this sets up things so that it can be used.

Notes:
Updates nuget.config to point to an internal feed which has the public feed as an upstream feed.
PGO needs to directly query the main feed, so I needed to duplicate the nuget.config to have a special version for pgo.

wil defines a macro CATCH_RETURN which conflicts with our own definition of CATCH_RETURN. So we rename ours to MUX_CATCH_RETURN.

@kmahone kmahone requested a review from ranjeshj June 9, 2022 17:41
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 9, 2022
@ojhad ojhad added area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team and removed needs-triage Issue needs to be triaged by the area owners labels Jun 10, 2022
@ranjeshj ranjeshj requested a review from llongley June 13, 2022 14:53
@kmahone kmahone merged commit 04f7859 into release/2.8cbs Jun 13, 2022
@kmahone kmahone deleted the user/kmahone/velocity branch June 13, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-DevInternal Internal build infrastructure, code cleanup, engineering efficiency team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants