Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavView: Navigation does not work when using Narrator in Scan Mode #7274

Merged
merged 2 commits into from
Jun 28, 2022

Conversation

kmahone
Copy link
Member

@kmahone kmahone commented Jun 23, 2022

NavViewItem AutomationPeer was intended to support Invoke Pattern, but didn't return correctly for GetPatternCore.
Not supporting Invoke causes problems when interacting with NavView via UIA, particularly when using Scan Mode in Narrator.

Closes #5998

@kmahone
Copy link
Member Author

kmahone commented Jun 23, 2022

/azp run

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Jun 23, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ranjeshj ranjeshj requested a review from ojhad June 24, 2022 14:28
@kmahone
Copy link
Member Author

kmahone commented Jun 24, 2022

Looks like NavViewItem AP not supporting Invoke pattern was an intentional change:
NavigationViewItem tab control type supports invoke pattern with PaneDisplayMode="Top" #2702

@kmahone
Copy link
Member Author

kmahone commented Jun 24, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone
Copy link
Member Author

kmahone commented Jun 24, 2022

Since we don't want to add Invoke back to NavViewItem AP (because of #2702), we instead double up UIA SelectionItem.Select() to also do an invoke. This makes SelectionItem.Select() equivalent to clicking on the item which is what desired in most cases.

@kmahone
Copy link
Member Author

kmahone commented Jun 24, 2022

@ojhad can you take a look at the latest iteration?

@kmahone kmahone changed the title NavViewItem AutomationPeer should support Invoke pattern Navigation does not work when using Narrator in Scan Mode Jun 27, 2022
@kmahone kmahone changed the title Navigation does not work when using Narrator in Scan Mode NavView: Navigation does not work when using Narrator in Scan Mode Jun 27, 2022
@kmahone
Copy link
Member Author

kmahone commented Jun 28, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kmahone kmahone merged commit a564c49 into main Jun 28, 2022
@kmahone kmahone deleted the user/kmahone/navviewinvoke branch June 28, 2022 20:50
@krschau krschau removed the needs-triage Issue needs to be triaged by the area owners label Jul 7, 2022
MartinZikmund added a commit to unoplatform/uno that referenced this pull request Sep 5, 2023
MartinZikmund added a commit to unoplatform/uno that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NavigationView] Navigation does not work when using Narrator in Scan Mode
3 participants