Revoke the items source view changed event if there is one irrespective of the oldValue #7277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve of the oldValue We sometimes seem to end up with handler that is not revoked because setting a new value for m_itemsSourceView before revoking causes the referenced value (pointed to by oldValue) becoming null. If the handler is not revoked, then we can end up in a crash if the events are being fired on a collection that is not the ItemsSource of repeater anymore. To avoid this completely, we can revoke the handler if there is one irrespective of the oldValue and also do it before saving the newValue.
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marcelwgn
approved these changes
Jun 25, 2022
RBrid
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes seem to end up with handler that is not revoked because setting a new value for m_itemsSourceView before revoking causes the referenced value (pointed to by oldValue) becoming null. If the handler is not revoked, then we can end up in a crash if the events are being fired on a collection that is not the ItemsSource of repeater anymore. To avoid this completely, we can revoke the handler if there is one irrespective of the oldValue and also do it before saving the newValue.