-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM, NIC and disk hydration #237
base: main
Are you sure you want to change the base?
Conversation
@damanMSFT can you please review this PR? I have already addressed the previous review comments. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
add NIC discover option in node agent
statuses["DownloadStatus"] = &dstate | ||
|
||
provisionStatus := status.GetProvisioningStatus() | ||
if provisionStatus != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are skipping (not adding into the map) if provisionStatus== nil? Is everyone aware of status map may not contains some statuses. or should we add the empty string for provisionStatus? Same approach should apply next 4 statuses.
@@ -15,6 +15,8 @@ enum Operation { | |||
IMPORT = 4; | |||
EXPORT = 5; | |||
VALIDATE = 6; | |||
HYDRATE = 7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets not add properties that are not required.
This PR is part of the VM, NIC and disk hydration feature that spans the whole HCI stack:
These changes include the protobuf changes required to create a new operation
HYDRATE