VM, NIC and disk hydration #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kybeak
reviewed
Aug 5, 2024
kybeak
approved these changes
Aug 5, 2024
kybeak
previously approved these changes
Aug 9, 2024
|
@damanMSFT can you please review this PR? I have already addressed the previous review comments. |
neerajdixit-msft2
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kybeak
previously approved these changes
Aug 12, 2024
add NIC discover option in node agent
mduppre
changed the title
kybeak
reviewed
Sep 7, 2024
| statuses["DownloadStatus"] = &dstate | ||
|
|
||
| provisionStatus := status.GetProvisioningStatus() | ||
| if provisionStatus != nil { |
There was a problem hiding this comment.
We are skipping (not adding into the map) if provisionStatus== nil? Is everyone aware of status map may not contains some statuses. or should we add the empty string for provisionStatus? Same approach should apply next 4 statuses.
madhanrm
reviewed
Sep 19, 2024
| @@ -15,6 +15,8 @@ enum Operation { | |||
| IMPORT = 4; | |||
| EXPORT = 5; | |||
| VALIDATE = 6; | |||
| HYDRATE = 7; | |||
There was a problem hiding this comment.
Lets not add properties that are not required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the VM, NIC and disk hydration feature that spans the whole HCI stack:
These changes include the protobuf changes required to create a new operation
HYDRATE