Fixed the returned values for PDOStatement::getColumnMeta (#946)

microsoft · Mar 8, 2019 · 7309fb9 · 7309fb9
1 parent d60748e
commit 7309fb9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/source/pdo_sqlsrv/pdo_stmt.cpp b/source/pdo_sqlsrv/pdo_stmt.cpp
@@ -1020,7 +1020,7 @@ int pdo_sqlsrv_stmt_get_attr( _Inout_ pdo_stmt_t *stmt, _In_ zend_long attr, _In
 // colno        - The index of the field for which to return the metadata.
 // return_value - zval* consisting of the metadata.
 // Return:
-// 0 for failure, 1 for success.
+// FAILURE for failure, SUCCESS for success.
 int pdo_sqlsrv_stmt_get_col_meta( _Inout_ pdo_stmt_t *stmt, _In_ zend_long colno, _Inout_ zval *return_value TSRMLS_DC)
 {
     PDO_RESET_STMT_ERROR;
@@ -1096,14 +1096,14 @@ int pdo_sqlsrv_stmt_get_col_meta( _Inout_ pdo_stmt_t *stmt, _In_ zend_long colno
     }
     catch( core::CoreException& ) {
 
-        return 0;
+        return FAILURE;
     }
     catch(...) {
 
         DIE( "pdo_sqlsrv_stmt_get_col_meta: Unknown exception occurred while retrieving metadata." );
     }
 
-    return 1;
+    return SUCCESS;
 }