Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check exception when finalizing output parameters #1143

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Check exception when finalizing output parameters #1143

merged 2 commits into from
Jun 22, 2020

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Jun 22, 2020

If an error occurs or an exception is thrown during an execution, the values of any output parameters or columns are undefined. Therefore, do not depend on them having any specific values, because the ODBC driver may or may not have modified them.

@coveralls
Copy link

coveralls commented Jun 22, 2020

Coverage Status

Coverage increased (+0.2%) to 75.002% when pulling e210371 on yitam:errOutParam into f45f257 on microsoft:dev.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #1143 into dev will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1143      +/-   ##
==========================================
+ Coverage   77.55%   77.87%   +0.31%     
==========================================
  Files          24       24              
  Lines        7280     7280              
==========================================
+ Hits         5646     5669      +23     
+ Misses       1634     1611      -23     
Impacted Files Coverage Δ
.../phpdev/vc15/x86/php-7.4.7-src/ext/sqlsrv/util.cpp 87.19% <0.00%> (-0.61%) ⬇️
.../x86/php-7.4.7-src/ext/sqlsrv/shared/core_stmt.cpp 84.45% <0.00%> (+0.21%) ⬆️
.../php-7.4.7-src/ext/pdo_sqlsrv/shared/core_stmt.cpp 80.67% <0.00%> (+0.84%) ⬆️
.../php-7.4.7-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h 84.18% <0.00%> (+3.25%) ⬆️
.../x86/php-7.4.7-src/ext/sqlsrv/shared/core_sqlsrv.h 82.26% <0.00%> (+3.44%) ⬆️

@yitam yitam merged commit d4a29fe into microsoft:dev Jun 22, 2020
@yitam yitam deleted the errOutParam branch June 22, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants