Binding integers as output parameters with correct C types #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1144 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 24 24
Lines 7280 7280
=======================================
Hits 5669 5669
Misses 1611 1611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #699 and #773
When testing issue #699 , found that if the output param was initialized to -1, the result is a big negative value -4294967173, which is essentially FFFF FFFF 0000 007B (note that 7B is 123 -- the expected value). Because in a 64-bit system, a 8-byte buffer is supplied.
For details please check C Data Types