Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified parse_param_array in sqlsrv #1262

Merged
merged 2 commits into from
May 27, 2021
Merged

Simplified parse_param_array in sqlsrv #1262

merged 2 commits into from
May 27, 2021

Conversation

yitam
Copy link
Contributor

@yitam yitam commented May 27, 2021

This simplifies the way the input, output and inout parameters are parsed which may speed up processing TVP parameters
Also fixed tvp tests that fail against older servers

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #1262 (a4218f9) into dev (0da75f5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1262      +/-   ##
==========================================
- Coverage   83.46%   83.45%   -0.01%     
==========================================
  Files          22       22              
  Lines        7795     7822      +27     
==========================================
+ Hits         6506     6528      +22     
- Misses       1289     1294       +5     
Impacted Files Coverage Δ
.../phpdev/vs16/x86/php-8.0.6-src/ext/sqlsrv/stmt.cpp 87.10% <0.00%> (-0.28%) ⬇️

@yitam yitam merged commit b49cb51 into dev May 27, 2021
@yitam yitam deleted the srvParse branch May 27, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant