Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ActiveDirectoryMsi Authentication behavior when specified UID #1374

Merged
merged 4 commits into from
Mar 18, 2022

Conversation

laclefyoshi
Copy link
Contributor

In case of Authentication = ActiveDirectoryMsi, UID may be specified when using user-managed identity.
This fix is for ActiveDirectoryMsi to use the specified UID.

MS Doc - Connect Using Azure Active Directory Authentication - Using the user-assigned managed identity with PDO_SQLSRV driver

@ghost
Copy link

ghost commented Feb 18, 2022

CLA assistant check
All CLA requirements met.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1374 (4649206) into dev (ba53591) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 4649206 differs from pull request most recent head 15576ec. Consider uploading reports for the commit 15576ec to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1374      +/-   ##
==========================================
- Coverage   83.63%   83.58%   -0.06%     
==========================================
  Files          22       22              
  Lines        7829     7841      +12     
==========================================
+ Hits         6548     6554       +6     
- Misses       1281     1287       +6     
Impacted Files Coverage Δ
...x86/php-8.0.17-src/ext/sqlsrv/shared/core_conn.cpp 80.62% <0.00%> (-1.12%) ⬇️
...php-8.0.17-src/ext/pdo_sqlsrv/shared/core_conn.cpp 85.75% <0.00%> (-0.05%) ⬇️

@absci
Copy link
Contributor

absci commented Mar 16, 2022

Thanks for your contribution. Could you pull the latest change from dev to your PR? It contains a small fix for the Appveyor, that pipeline is required to pass before merging.

@laclefyoshi
Copy link
Contributor Author

Thank you for your approval!
I've fetched changes of dev.

@absci absci merged commit a11822b into microsoft:dev Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants