Fix empty string bind param causes floating point exception #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1960,7 +1960,7 @@ void default_sql_size_and_scale( sqlsrv_stmt* stmt, unsigned int paramno, zval* | |||
| column_size = SQL_SERVER_MAX_TYPE_SIZE; | |||
| } | |||
| else { | |||
| column_size = SQL_SERVER_MAX_FIELD_SIZE / char_size; | |||
| column_size = (char_size == 0) ? 1 : (SQL_SERVER_MAX_FIELD_SIZE / char_size); | |||
There was a problem hiding this comment.
char_size is computed differently on Windows:
Maybe not multiplying with the parameter string size would be a better fix?
Explaining the reason why the code changed in 4.0.3 would also help.
|
@xalopp thanks a ton for the PR. Your fix is definitely in the right direction. The problem is with character size when it is 0, so on line 1957 when we are calculating the char size, we don’t need the length of the parameter, and removing Z_STRLEN_P( param_z ) from char_size would solve this issue. We believe that will fix this issue along with some other idiosyncrasies that we observed. Stay tuned for our next release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141 and Fixes #144