Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

safeguard get_col_meta #261

Merged
merged 1 commit into from
Jan 28, 2017
Merged

safeguard get_col_meta #261

merged 1 commit into from
Jan 28, 2017

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Jan 27, 2017

this is meant to fix issue #224

@yitam yitam requested a review from v-kigos January 27, 2017 23:09
@v-kigos
Copy link
Contributor

v-kigos commented Jan 27, 2017

MSDN does not define return values for this case,
see https://msdn.microsoft.com/en-us/library/ff628182(v=sql.105).aspx
PHP help suggests: Returns FALSE if the requested column does not exist in the result set, or if no result set exists, see http://php.net/manual/en/pdostatement.getcolumnmeta.php

@yitam
Copy link
Contributor Author

yitam commented Jan 27, 2017

Yes, did you read the warning message on PHP.net? :)
So you suggest that we simply return FALSE without any message?

@v-kigos v-kigos merged commit c24dc05 into microsoft:merged-codebase Jan 28, 2017
@yitam yitam deleted the columnMeta branch January 28, 2017 00:34
@yitam yitam mentioned this pull request Jan 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-kigos v-kigos Awaiting requested review from v-kigos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yitam @v-kigos