-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert nextRowset changes #595
Revert nextRowset changes #595
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please justify in this pull request why reverting to the previous way is necessary. Also, the tests can be further simplified / refactored to use much less code (too many repeated lines). It would also be easier to understand the test if you compare expected results / error messages within the test itself rather than relying on the expected output
Codecov Report
@@ Coverage Diff @@
## dev #595 +/- ##
==========================================
- Coverage 74.47% 74.31% -0.16%
==========================================
Files 50 50
Lines 14949 14900 -49
==========================================
- Hits 11133 11073 -60
- Misses 3816 3827 +11
Continue to review full report at Codecov.
|
Reverting changes because several users have run into errors under the changes made to the way empty and null results are handled, and because the changes caused problems with multi-query statements. The original approach generally produced error messages only upon fetching, and next_result or nextRowset should simply move the cursor.
This change is