520changelog #722
520changelog #722
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #722 +/- ##
=======================================
Coverage 78.95% 78.95%
=======================================
Files 25 25
Lines 7188 7188
=======================================
Hits 5675 5675
Misses 1513 1513Continue to review full report at Codecov.
|
CHANGELOG.md
Outdated
| - Support for inserting into and modifying an encrypted column | ||
| - Support for fetching from an encrypted column | ||
| - Added support for PHP 7.2 | ||
| - Added support for MSODBC 17 |
There was a problem hiding this comment.
can we be a bit more consistent with the naming? Sometimes we say "MSODBC" and sometimes "ODBC Driver". I think it should be "MS ODBC Driver", what do you think?
CHANGELOG.md
Outdated
| - Added support for Ubuntu 17 (requires MSODBC 17) | ||
| - Added support for Debian 9 (requires MSODBC 17) | ||
| - Added support for SUSE 12 | ||
| - Added Driver option to set the ODBC driver, Added "Driver" option, valid values are ODBC Driver 17 for SQL Server,ODBC Driver 13 for SQL Server, and ODBC Driver 11 for SQL Server |
There was a problem hiding this comment.
minor pickiness, space after ","
There was a problem hiding this comment.
also, quotes around "ODBC Driver xx"?
CHANGELOG.md
Outdated
| - BIGINT as an output param no longer results in value out of range exception when the returned value is larger than a maximum integer ([PR #567](https://github.com/Microsoft/msphpsql/pull/567)) | ||
|
|
||
| ### Removed | ||
| - No longer support Ubuntu 15 |
There was a problem hiding this comment.
I think it's better to say "Dropped support for Ubuntu 15"
CHANGELOG.md
Outdated
|
|
||
| ### Removed | ||
| - No longer support Ubuntu 15 | ||
| - Supplying tablename into PDO::lastInsertId($name) no longer return the last inserted row ([lastInsertId](https://github.com/Microsoft/msphpsql/wiki/Features#lastinsertid)) |
There was a problem hiding this comment.
This is mentioned in the fixed section, no need to mention it here.
There was a problem hiding this comment.
I think Jenny agreed to add it in both places since it is a breaking change. I'll leave it here.
CHANGELOG.md
Outdated
| - Supplying tablename into PDO::lastInsertId($name) no longer return the last inserted row ([lastInsertId](https://github.com/Microsoft/msphpsql/wiki/Features#lastinsertid)) | ||
|
|
||
| ### Limitations | ||
| - Always Encrypted is not support in Linux and macOS |
CHANGELOG.md
Outdated
|
|
||
| ### Limitations | ||
| - Always Encrypted is not support in Linux and macOS | ||
| - In Linux and macOS, setlocale() only takes effect if it is invoked before the first connection. The subsequent locale setting will not work |
There was a problem hiding this comment.
'The subsequent locale setting will not work' - this is awkward. Maybe 'Attempting to set the locale after connection will not work'?
CHANGELOG.md
Outdated
| - No support for inout / output params when using sql_variant type | ||
|
|
||
| ### Known Issues | ||
| - Connection pooling on Linux doesn't work properly when using the MSODBC 17 |
CHANGELOG.md
Outdated
| - When pooling is enabled in Linux or macOS | ||
| - unixODBC <= 2.3.4 (Linux and macOS) might not return proper diagnostics information, such as error messages, warnings and informative messages | ||
| - due to this unixODBC bug, fetch large data (such as xml, binary) as streams as a workaround. See the examples [here](https://github.com/Microsoft/msphpsql/wiki/Connection-Pooling-on-Linux-and-Mac) | ||
| - Connection with Connection Resiliency enabled so not resume properly with Connection Pooling (Issue [#678](https://github.com/Microsoft/msphpsql/issues/678)) |
There was a problem hiding this comment.
I think this should be 'Connection with Connection Resiliency enabled does not resume properly with Connection Pooling enabled'?
This change is