Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the new issue template #752

Merged
merged 3 commits into from
Apr 20, 2018
Merged

Modified the new issue template #752

merged 3 commits into from
Apr 20, 2018

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Apr 20, 2018

Install ODBC 17.1 and fix pip install issue as well

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Apr 20, 2018

Codecov Report

Merging #752 into dev will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #752      +/-   ##
==========================================
- Coverage   78.91%   78.85%   -0.06%     
==========================================
  Files          25       25              
  Lines        7157     7157              
==========================================
- Hits         5648     5644       -4     
- Misses       1509     1513       +4
Impacted Files Coverage Δ
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_conn.cpp 80.63% <0%> (-0.71%) ⬇️
...php-7.1.16-src/ext/pdo_sqlsrv/shared/core_conn.cpp 86.26% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a531d9...c553105. Read the comment docs.

@yitam yitam requested a review from lilgreenbird April 20, 2018 19:19
+
+## Client operating system
+Please tell us what oprating system the client program is running on.
+What operating system the client program is running on:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a little consistent with the other sections.
Should be "The operation system the client program is running on:"
Actually, the word "The" isn't really necessary.

@yitam yitam merged commit b34d5bd into microsoft:dev Apr 20, 2018
@yitam yitam deleted the template branch April 20, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants