Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the bvt streams tests #782

Merged
merged 1 commit into from
May 25, 2018
Merged

Fixed the bvt streams tests #782

merged 1 commit into from
May 25, 2018

Conversation

yitam
Copy link
Contributor

@yitam yitam commented May 25, 2018

This change is Reviewable

@coveralls
Copy link

coveralls commented May 25, 2018

Coverage Status

Coverage remained the same at 74.697% when pulling 9e8d674 on yitam:FixStreamTests into 8f5c706 on Microsoft:dev.

@codecov-io
Copy link

codecov-io commented May 25, 2018

Codecov Report

Merging #782 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #782   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files          25       25           
  Lines        7323     7323           
=======================================
  Hits         5863     5863           
  Misses       1460     1460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f5c706...9e8d674. Read the comment docs.

@david-puglielli
Copy link
Contributor

Wasn't there another error in one test where t output 'Done' instead of another message, and that test failed? I think the test was fine, just the output was different from expected.

@yitam
Copy link
Contributor Author

yitam commented May 25, 2018

yes @david-puglielli I've already fixed that expected output without creating a pull request 👍

@yitam yitam merged commit fbd686c into microsoft:dev May 25, 2018
@yitam yitam deleted the FixStreamTests branch May 25, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants