Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For these AKV tests check env despite not AE connected #791

Merged
merged 1 commit into from
Jun 7, 2018
Merged

For these AKV tests check env despite not AE connected #791

merged 1 commit into from
Jun 7, 2018

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Jun 7, 2018

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Jun 7, 2018

Codecov Report

Merging #791 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #791   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files          25       25           
  Lines        7325     7325           
=======================================
  Hits         5865     5865           
  Misses       1460     1460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a66610...f6e450b. Read the comment docs.

die("skip extension not loaded");
}

require_once('MsCommon.inc');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MsHelper included by MsCommon.inc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@yitam yitam merged commit 90c6443 into microsoft:dev Jun 7, 2018
@yitam yitam deleted the fixODBC13tests branch June 7, 2018 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants