Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 909 fix #990

Merged
merged 2 commits into from
May 13, 2019
Merged

Issue 909 fix #990

merged 2 commits into from
May 13, 2019

Conversation

david-puglielli
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented May 11, 2019

Coverage Status

Coverage increased (+0.006%) to 73.942% when pulling 1aa8dea on david-puglielli:issue-909-fix into 3b6b076 on microsoft:dev.

@codecov-io
Copy link

codecov-io commented May 11, 2019

Codecov Report

Merging #990 into dev will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #990      +/-   ##
==========================================
+ Coverage   78.65%   78.71%   +0.06%     
==========================================
  Files          25       25              
  Lines        8133     8133              
==========================================
+ Hits         6397     6402       +5     
+ Misses       1736     1731       -5
Impacted Files Coverage Δ
...x86/php-7.1.29-src/ext/sqlsrv/shared/core_stmt.cpp 84.95% <0%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b6b076...1aa8dea. Read the comment docs.

Copy link
Contributor

@yitam yitam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please fix coding style first though

@david-puglielli david-puglielli merged commit e152459 into microsoft:dev May 13, 2019
@david-puglielli
Copy link
Contributor Author

Issue #909 fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants