Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ubuntu 23.10 to OneBranch.Publish.yml. #4073

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Add Ubuntu 23.10 to OneBranch.Publish.yml. #4073

merged 1 commit into from
Jan 24, 2024

Conversation

alexrp
Copy link
Contributor

@alexrp alexrp commented Jan 23, 2024

I have no idea if this is all that needs to happen to add Ubuntu 23.10 support; I'm just going off what was done in #3652. 🙂

@nibanks
Copy link
Member

nibanks commented Jan 23, 2024

It looks correct to me. Thanks for the PR! @csujedihy to verify.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f357915) 87.18% compared to head (0be4261) 86.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4073      +/-   ##
==========================================
- Coverage   87.18%   86.89%   -0.29%     
==========================================
  Files          56       56              
  Lines       16938    16938              
==========================================
- Hits        14767    14719      -48     
- Misses       2171     2219      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@csujedihy csujedihy merged commit 463e89c into microsoft:main Jan 24, 2024
350 of 353 checks passed
@alexrp
Copy link
Contributor Author

alexrp commented Jan 25, 2024

Will 23.10 packages start showing up automatically, or does someone have to manually trigger the job? 👀

@nibanks
Copy link
Member

nibanks commented Jan 25, 2024

Will 23.10 packages start showing up automatically, or does someone have to manually trigger the job? 👀

This is a manual job we do run for new releases. So the next release will have this.

@alexrp
Copy link
Contributor Author

alexrp commented Jan 27, 2024

Just to confirm that everything works as expected after v2.3.0 was released yesterday:

❯ sudo apt install libmsquic 
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following NEW packages will be installed:
  libmsquic
0 upgraded, 1 newly installed, 0 to remove and 0 not upgraded.
Need to get 4.112 kB of archives.
After this operation, 13,8 MB of additional disk space will be used.
Get:1 https://packages.microsoft.com/ubuntu/23.10/prod mantic/main amd64 libmsquic amd64 2.3.0 [4.112 kB]
Fetched 4.112 kB in 3s (1.499 kB/s)    
Selecting previously unselected package libmsquic.
(Reading database ... 960921 files and directories currently installed.)
Preparing to unpack .../libmsquic_2.3.0_amd64.deb ...
Unpacking libmsquic (2.3.0) ...
Setting up libmsquic (2.3.0) ...

@nibanks
Copy link
Member

nibanks commented Jan 28, 2024

Just to confirm that everything works as expected after v2.3.0 was released yesterday:

Great to hear! I actually forgot we got the publishing to happen automatically on tag creation. 😄 Please let us know if you have any problems with v2.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants