-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log QUIC_TLS_SECRETS on all TestConnections and write to disk on cleanup #4349
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4349 +/- ##
==========================================
- Coverage 86.56% 85.73% -0.83%
==========================================
Files 56 56
Lines 15521 15521
==========================================
- Hits 13435 13307 -128
- Misses 2086 2214 +128 ☔ View full report in Codecov by Sentry. |
…to disk on cleanup.
… it still crashes.
68f814f
to
343a1e9
Compare
I can't repro the test failure locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Logs QUIC_TLS_SECRETs on all TestConnections. If a filepath is provided, then it will write the QUIC_TLS_SECRETS in an sslkeylogfile format to the provided file path when the TestConnection is destructed.
Testing
CI
Documentation
N/A