Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Prepare Machine and Checkout from Linux Package Testing #4456

Conversation

liveans
Copy link
Member

@liveans liveans commented Aug 13, 2024

Description

Linux packages should work without needing to prepare the machine or checkout msquic. This PR removes the unnecessary steps.

Testing

CI tests should pass

Documentation

No

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (b01cef9) to head (34e10b1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4456      +/-   ##
==========================================
- Coverage   86.01%   85.77%   -0.25%     
==========================================
  Files          56       56              
  Lines       15521    15521              
==========================================
- Hits        13351    13313      -38     
- Misses       2170     2208      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liveans liveans marked this pull request as ready for review August 13, 2024 21:39
@liveans liveans requested a review from a team as a code owner August 13, 2024 21:39
@nibanks nibanks enabled auto-merge (squash) August 13, 2024 21:45
@nibanks nibanks merged commit dd316f7 into microsoft:main Aug 13, 2024
447 checks passed
@liveans liveans deleted the delete_unnecessary_steps_on_package_linux_gh_action branch August 13, 2024 21:59
ami-GS pushed a commit that referenced this pull request Aug 15, 2024
* Prepare Machine and msquic checkout should not be necessary for testing linux packages

* Install dependencies with package

* Try to fix dependencies

* Fix validated set
ami-GS added a commit that referenced this pull request Aug 15, 2024
* Delete Prepare Machine and Checkout from Linux Package Testing (#4456)

* Prepare Machine and msquic checkout should not be necessary for testing linux packages

* Install dependencies with package

* Try to fix dependencies

* Fix validated set

* Publish package to more distros and refactoring (#4455)

* Publish package to more distros and refactoring

* fix?

* fix

* fix

* fix file dependencies

* fix

* fix

* fix

* fix

* Make rpm package for x86_64 (#4459)

* Make rpm package for x86_64

* Accidentally deleted debug flag

* fix syntax

* add azure linux3 arm

* increment patch 2.4.4

---------

Co-authored-by: Ahmet Ibrahim Aksoy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants