Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compile for Android and compatible to API-21 #4486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

st-jliu
Copy link
Contributor

@st-jliu st-jliu commented Aug 23, 2024

Description

Cross compile to support Android device. Old version Android NDK provide a limited posix API sets, need provide backward compatible usage.

Testing

CI/CD

Documentation

N/A

@st-jliu st-jliu requested a review from a team as a code owner August 23, 2024 08:00
@st-jliu
Copy link
Contributor Author

st-jliu commented Aug 23, 2024

@st-jliu please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@nibanks
Copy link
Member

nibanks commented Aug 29, 2024

I'm not sure we really want/need to support such an old (2014?) version of Android, considering the overhead it creates in the code. There are zero tests for the code you've added, and we will have no confidence we don't break this (or that it actually works today) going forward.

@st-jliu
Copy link
Contributor Author

st-jliu commented Sep 3, 2024

The patch is for platform that use old libc, recvmmsg() introduced since glibc 2.12, epoll_create1() introduced since glibc 2.9.
And my MacOS 14.6 use Standard C Library also did not provide recvmmsg()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants