-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Java 9-specific class references from the Java 8 jar #1626
Conversation
…der a newer JVM but the expected result is dependent on what Java version the jar was built with.
We need to be able to build with JDK 1.8 - it seems there's an override in SqlServerDatabaseMetadata that should be split in a separate *43 class respectively and excluded for jre8 build.
|
@cheenamalhotra I saw that when I tried building with JDK 1.8. Since that class wasn't mentioned in the original issue, I thought I could skip it and hope the reference checking that is happening at load time in their scenario is not evaluating overrides. |
Yes, it's resolved on runtime as Java 8 doesn't have the API to override so it ignores but we should consider Eclipse environment errors too, and exclude all that contributes to errors. I would say this code is still present that's not applicable to jre8 and could be removed with no risk. |
No description provided.