Cache Parameter Metadata #1845

Jeffery-Wasty · 2022-06-13T17:27:53Z

Cache sp_describe_parameter_encryption calls to improved performance by reducing trips to the server. For now, supports AE without secure enclaves, with enclave support (v3) to be added in a later update.

…g options

…lave retry

…ft/mssql-jdbc into cache-parameter-metadata

src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java

src/main/java/com/microsoft/sqlserver/jdbc/AE.java

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java

src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java

…p to ConcurrentHashMap

…r on test setup method.

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java

src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerEnclaveProvider.java

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java

lilgreenbird · 2022-06-21T19:14:55Z

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java

+     * @return true, if the metadata for the query can be retrieved
+     * 
+     */
+    static boolean getQueryMetadata(Parameter[] params, ArrayList<String> parameterNames,


we don't need all these static methods this takes up memory. The caller should create an instance of the cache and invoke the methods

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java

…a future time.

… alongside the error code.

David-Engel

LGTM

…s problems, test will still correctly assess the error code path in ParameterMetaDataCache

…n correctly.

alex-bochkov · 2022-06-22T22:06:20Z

@Jeffery-Wasty this is an exciting change! Thank you for working on it!
Are there documents that explain how exactly this process works?

What's the cache TTL?
Is it possible to disable cache if needed? For example, if we need to make schema changes and make sure the app won't break in the middle.

Jeffery-Wasty · 2022-06-22T22:42:35Z

Hi @alex-bochkov,

We'll be releasing documentation regarding new features shortly, in the meantime I can answer the questions you have included:

1. What's the cache TTL?

The cache doesn't have an independent TTL, rather the enclave session it belongs to has a TTL of eight hours.

2. Is it possible to disable cache if needed? For example, if we need to make schema changes and make sure the app won't break in the middle.

It's not possible to disable the cache at the moment. This is something we can potentially add a later time, however current efforts are towards extending caching for secure enclave scenarios.

Jeffery-Wasty added 2 commits June 13, 2022 10:26

Cache parameter metadata - missing completed tests + connection strin…

56ee9c2

…g options

Merge branch 'main' into cache-parameter-metadata

09c2892

Jeffery-Wasty requested review from lilgreenbird, tkyc and VeryVerySpicy June 13, 2022 17:30

Jeffery-Wasty added 2 commits June 15, 2022 09:52

Added secure enclave retry logic + testing for caching and secure enc…

7839ea3

…lave retry

Merge branch 'cache-parameter-metadata' of https://github.com/microso…

f4f73b6

…ft/mssql-jdbc into cache-parameter-metadata

Jeffery-Wasty marked this pull request as ready for review June 15, 2022 16:54

Added some things with testing.

810a019

Jeffery-Wasty added this to the 11.1.2 milestone Jun 15, 2022

Jeffery-Wasty self-assigned this Jun 15, 2022

Jeffery-Wasty added the Under Review Used for pull requests under review label Jun 15, 2022

Fixed DriverJDBCVersion naming

9b25fd7

tkyc reviewed Jun 15, 2022

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java Show resolved Hide resolved

Jeffery-Wasty added 4 commits June 15, 2022 11:36

Fixed another issue regarding the enclave keys

729626c

Chaged AKV to WKS

d6b00e5

Added comments and cleaned up code a bit

1c5655d

Added 'reqExternalSetup' tags to prevent failures in public pipelines

20bc4cf

lilgreenbird reviewed Jun 16, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/AE.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 16, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 16, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 16, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

VeryVerySpicy reviewed Jun 17, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 19, 2022

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 19, 2022

View reviewed changes

src/test/java/com/microsoft/sqlserver/jdbc/parametermetadata/ParameterMetaDataCacheTest.java Outdated Show resolved Hide resolved

Jeffery-Wasty added 4 commits June 20, 2022 09:45

Fixed access modifiers, exceptions, few lines in test, changed HashMa…

a1857d1

…p to ConcurrentHashMap

Removed extra lines in SQLQueryMetadataCache + changed access modifie…

b1e0962

…r on test setup method.

Changed tags on tests.

7473cc0

Added a missing description.

dc8a6b2

lilgreenbird reviewed Jun 21, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 21, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 21, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerEnclaveProvider.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 21, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 21, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

lilgreenbird reviewed Jun 21, 2022

View reviewed changes

src/main/java/com/microsoft/sqlserver/jdbc/SQLQueryMetadataCache.java Outdated Show resolved Hide resolved

Jeffery-Wasty added 4 commits June 21, 2022 15:03

Code clean up, more logging, better error handling + negative testing

482193e

Removed db name padding as its no longer necessary.

8bbc122

Removed method in ParameterMetaDataCache that will not be used until …

8025c30

…a future time.

Changed errors in ParamaterMetaDataCache to include the error message…

b2d09e1

… alongside the error code.

lilgreenbird previously approved these changes Jun 21, 2022

View reviewed changes

David-Engel previously approved these changes Jun 21, 2022

View reviewed changes

In SQLServerConnectionTest, specifying columnEncryption=enabled cause…

345ef9f

…s problems, test will still correctly assess the error code path in ParameterMetaDataCache

Jeffery-Wasty dismissed stale reviews from David-Engel and lilgreenbird via 345ef9f June 21, 2022 23:23

tkyc previously approved these changes Jun 21, 2022

View reviewed changes

lilgreenbird previously approved these changes Jun 21, 2022

View reviewed changes

One small change in ISQLServerEnclaveProvider to allow AE tests to ru…

64c4783

…n correctly.

Jeffery-Wasty dismissed stale reviews from lilgreenbird and tkyc via 64c4783 June 22, 2022 16:14

tkyc approved these changes Jun 22, 2022

View reviewed changes

VeryVerySpicy approved these changes Jun 22, 2022

View reviewed changes

lilgreenbird approved these changes Jun 22, 2022

View reviewed changes

lilgreenbird merged commit a417222 into main Jun 22, 2022

Jeffery-Wasty removed the Under Review Used for pull requests under review label Jun 22, 2022

Jeffery-Wasty deleted the cache-parameter-metadata branch June 22, 2022 21:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cache Parameter Metadata #1845

Cache Parameter Metadata #1845

Jeffery-Wasty commented Jun 13, 2022 •

edited

Loading

lilgreenbird Jun 21, 2022 •

edited

Loading

David-Engel left a comment

alex-bochkov commented Jun 22, 2022 •

edited

Loading

Jeffery-Wasty commented Jun 22, 2022

Cache Parameter Metadata #1845

Cache Parameter Metadata #1845

Conversation

Jeffery-Wasty commented Jun 13, 2022 • edited Loading

lilgreenbird Jun 21, 2022 • edited Loading

Choose a reason for hiding this comment

David-Engel left a comment

Choose a reason for hiding this comment

alex-bochkov commented Jun 22, 2022 • edited Loading

Jeffery-Wasty commented Jun 22, 2022

Jeffery-Wasty commented Jun 13, 2022 •

edited

Loading

lilgreenbird Jun 21, 2022 •

edited

Loading

alex-bochkov commented Jun 22, 2022 •

edited

Loading