Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for running tests with managed identity #2416

Merged
merged 14 commits into from
May 21, 2024
Merged

Updates for running tests with managed identity #2416

merged 14 commits into from
May 21, 2024

Conversation

lilgreenbird
Copy link
Contributor

No description provided.

@lilgreenbird lilgreenbird added this to the 12.7.1 milestone May 14, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.11%. Comparing base (2a25d8f) to head (3c51080).
Report is 1 commits behind head on main.

Current head 3c51080 differs from pull request most recent head ff656e2

Please upload reports for the commit ff656e2 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2416      +/-   ##
============================================
- Coverage     50.24%   50.11%   -0.13%     
+ Complexity     3843     3832      -11     
============================================
  Files           145      145              
  Lines         33355    33355              
  Branches       5654     5654              
============================================
- Hits          16758    16717      -41     
- Misses        14205    14239      +34     
- Partials       2392     2399       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty
Copy link
Contributor

Jeffery-Wasty commented May 17, 2024

Also can you remove the comment in SharedTimerTest::32,33.

tkyc
tkyc previously approved these changes May 21, 2024
tkyc
tkyc previously approved these changes May 21, 2024
Jeffery-Wasty
Jeffery-Wasty previously approved these changes May 21, 2024
@lilgreenbird lilgreenbird dismissed stale reviews from Jeffery-Wasty and tkyc via ff656e2 May 21, 2024 22:30
@lilgreenbird lilgreenbird merged commit a35798e into main May 21, 2024
4 of 17 checks passed
@Jeffery-Wasty Jeffery-Wasty deleted the secrets branch May 22, 2024 19:23
tkyc added a commit that referenced this pull request May 23, 2024
* Updates for running tests with managed identity (#2416)

* Updated tests for removal of secrets

* Reverted TimeoutTests

* AE config port

* TimeoutTests update

---------

Co-authored-by: lilgreenbird <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

3 participants