Fix QueryTime unit change #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebryan
approved these changes
Jan 29, 2022
|
Hey @kubajir we are putting together a blog on all the contributions we had to MSTICPy in the last month. Are you happy for us to mention you in this blog and if so how do you want us to do this? It could be your name, GitHub username, Twitter handle. Whatever you want really. |
|
Hey @petebryan, sure. Feel free to use my real name (and/or GitHub username), would be nice if you could also include the company name - Chr. Hansen. |
juju4
pushed a commit
to juju4/msticpy
that referenced
this pull request
Jun 5, 2022
Fix QueryTime unit change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make sure we update the actual start/end values when there is a time unit change within the QueryTime widget. Similarly to time range updates. This becomes apparent whenever the unit change isn't accompanied by the default time range change (e.g. days -> weeks).