Skip to content

Commit

Permalink
Remove MemoryAttributeProtocolFuncTestApp (#286)
Browse files Browse the repository at this point in the history
## Description

The MemoryAttributeProtocolFuncTestApp only had an X64 implementation
and requires an AARCH64 implementation to test the AARCH64
implementation of the MemoryAttributeProtocol. However, one of the tests
in this package requires ArmPkg/ArmLib to get the translation table base
address and use various translation table macros. Because adding a
dependency on ArmPkg would break our rule of no CI dependencies between
MU_BASECORE and other repos, this test will be removed from MdePkg and
added to MU_PLUS/UefiTestingPkg.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

N/A

## Integration Instructions

N/A
  • Loading branch information
TaylorBeebe authored and kenlautner committed May 9, 2023
1 parent da67fcd commit 22409a5
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 837 deletions.
2 changes: 0 additions & 2 deletions MdePkg/MdePkg.dsc
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@

[Components.IA32, Components.X64, Components.AARCH64]
MdePkg/Library/BaseRngLib/BaseRngLib.inf
# TCBZ3519 MU_CHANGE: UEFI shell test for MemoryAttributeProtocol
MdePkg/Test/ShellTest/MemoryAttributeProtocolFuncTestApp/MemoryAttributeProtocolFuncTestApp.inf

[Components.IA32, Components.X64]
MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
Expand Down
Loading

0 comments on commit 22409a5

Please sign in to comment.