Skip to content

Commit

Permalink
Fix dmpstore regressed during CodeQL changes (#382)
Browse files Browse the repository at this point in the history
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

During one of the CodeQL changes, the `dmpstore` command was no longer
functional if the input was `dmpstore -all`.

This was caused because the NULL pointer check incorrectly return the
function, which is what occurs when using `-all` option. The
`ProcessVariables` will properly handle NULL input for `Name`.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This was tested on ARM FVP and QEMU virtual platforms.

## Integration Instructions

N/A
  • Loading branch information
kuqin12 authored Apr 28, 2023
1 parent 8b00f3f commit c3b4b32
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
Original file line number Diff line number Diff line change
Expand Up @@ -823,12 +823,6 @@ ShellCommandRunDmpStore (
// Get the Name of the variable to find
//
Name = ShellCommandLineGetRawValue (Package, 1);
// MU_CHANGE [BEGIN] - CodeQL change
if (Name == NULL) {
return (SHELL_INVALID_PARAMETER);
}

// MU_CHANGE [END] - CodeQL change

if (ShellStatus == SHELL_SUCCESS) {
if (ShellCommandLineGetFlag (Package, L"-s")) {
Expand Down

0 comments on commit c3b4b32

Please sign in to comment.